Skip to content

Conversation

@jayudey-wf
Copy link
Contributor

@jayudey-wf jayudey-wf commented Nov 3, 2017

Issue

  • It was pointed out that there was an inconsistency in the content_shell window size between the test and coverage task.

Changes

Source:

  • Update the content_shell window size in the coverage task to match the window size in the test task.

Tests:

  • n/a, contant update

Areas of Regression

  • Coverage task

Testing

  • passing CI

Code Review

@Workiva/web-platform-pp
fyi: @aaronlademann-wf

@codecov-io
Copy link

codecov-io commented Nov 3, 2017

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files           7        7           
  Lines         173      173           
=======================================
  Hits           37       37           
  Misses        136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1014163...f61a5b2. Read the comment docs.

@aaronlademann-wf
Copy link
Contributor

+1

@jayudey-wf
Copy link
Contributor Author

ready for +10 and merge

@evanweible-wf
Copy link
Contributor

+10

  • Passing CI

@evanweible-wf
Copy link
Contributor

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit tests created/updated
    • n/a
  • All unit tests pass

Merging into master.

@evanweible-wf evanweible-wf merged commit 4cd9a21 into master Nov 9, 2017
@evanweible-wf evanweible-wf deleted the coverage-window-size branch November 9, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants