Skip to content

Conversation

@jayudey-wf
Copy link
Contributor

Issue

  • There was no way to specify both vm and browser in a generated runner file.

Changes

Source:

  • Added an additional platform option.

Tests:

  • added

Areas of Regression

  • gen-test-runner platform configuration and html generation

Testing

  • verify that tests work as exists

Code Review

@Workiva/ui-platform-pp @Workiva/web-platform-pp

@aaronlademann-wf
Copy link
Contributor

+10

@jacehensley-wf
Copy link
Contributor

+1

@evanweible-wf
Copy link
Contributor

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit tests created/updated
  • All unit tests pass

Merging into master.

@evanweible-wf evanweible-wf merged commit 5599d52 into master Dec 6, 2017
@evanweible-wf evanweible-wf deleted the generated-runner-both-annotation branch December 6, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants