Skip to content

Conversation

@evanweible-wf
Copy link
Contributor

Issue

#27

Changes

Prep pubspec.yaml for OSS

  • description
  • authors
  • homepage
  • environment

Areas of Regression

  • n/a

Testing

  • pub publish --dry-run shows no errors

TODO

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@maxwellpeterson-wf
Copy link
Member

+1

@jayudey-wf jayudey-wf changed the title Ready pubspec.yaml for OSS Ready pubspec.yaml for OSS, dart_dev Aug 18, 2015
@jayudey-wf jayudey-wf changed the title Ready pubspec.yaml for OSS, dart_dev CP-842 Ready pubspec.yaml for OSS, dart_dev Aug 18, 2015
pubspec.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we get a consistent order here? alphabetical or something?

@evanweible-wf
Copy link
Contributor Author

@trentgrover-wf done

@trentgrover-wf
Copy link
Contributor

+1

1 similar comment
@maxwellpeterson-wf
Copy link
Member

+1

@evanweible-wf
Copy link
Contributor Author

@jayudey-wf ready for merge.

@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • ran dry run after pulling in the license files from master and there were no errors after the publish command
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 18, 2015
CP-842 Ready pubspec.yaml for OSS, dart_dev
@jayudey-wf jayudey-wf merged commit 73a2aae into master Aug 18, 2015
@trentgrover-wf trentgrover-wf deleted the pubspec branch August 19, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants