Skip to content

Conversation

@evanweible-wf
Copy link
Contributor

Dependent on #39.

Issue

#30 Setup codecov.io reporting.

Changes

  • Add bash reporter step to travis CI build.
  • Add codecov.io badge to readme

Areas of Regression

  • n/a

Testing

  • CI build runs and passes and the codecov bash reporter successfully found the coverage.lcov file and uploaded it to codecov.io (build logs should indicate this).
  • Codecov report should show up here: https://codecov.io/github/Workiva/dart_dev

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@trentgrover-wf
Copy link
Contributor

+1
assuming that the CI ever finishes...
(from reviewing travis...codecov)

@codecov-io
Copy link

Current coverage is 52.11%

Branch #40 has no coverage reports uploaded yet.

Powered by Codecov. Updated on successful CI builds.

@jayudey-wf jayudey-wf changed the title Codecov.io Codecov.io, dart_dev Aug 19, 2015
@jayudey-wf jayudey-wf changed the title Codecov.io, dart_dev CP-859 Codecov.io, dart_dev Aug 19, 2015
@evanweible-wf
Copy link
Contributor Author

@trentgrover-wf @maxwellpeterson-wf @dustinlessard-wf rebased on latest master, and it is now correctly reporting only one coverage.lcov file.

@trentgrover-wf
Copy link
Contributor

+1

2 similar comments
@dustinlessard-wf
Copy link

+1

@maxwellpeterson-wf
Copy link
Member

+1

@maxwellpeterson-wf
Copy link
Member

@jayudey-wf ready for merge

@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • coverage is accurately reported to coverage.io
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 19, 2015
CP-859 Codecov.io, dart_dev
@jayudey-wf jayudey-wf merged commit a525435 into master Aug 19, 2015
@evanweible-wf evanweible-wf mentioned this pull request Aug 19, 2015
@trentgrover-wf trentgrover-wf deleted the codecov branch August 19, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants