CP-864 Explicitly exit process when dart_dev has finished #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When a project has a custom
tool/dev.dartconfiguration, dart_dev has to spawn a process to take advantage of that. Dart_dev then waits for that process to complete before exiting the main process. It's possible that this sub process may fail to complete, even if the dart_dev task has completed successfully.Changes
Source:
dev()file that acts as the entry point for the executable (either through the default usage or through the sub-process scenario that runs a project'stool/dev.dartfile) now explicitly exits the process to force completion of the parent task.Tests:
Areas of Regression
Testing
Code Review
@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf