Skip to content

Conversation

@evanweible-wf
Copy link
Contributor

Issue

When a project has a custom tool/dev.dart configuration, dart_dev has to spawn a process to take advantage of that. Dart_dev then waits for that process to complete before exiting the main process. It's possible that this sub process may fail to complete, even if the dart_dev task has completed successfully.

Changes

Source:

  • The dev() file that acts as the entry point for the executable (either through the default usage or through the sub-process scenario that runs a project's tool/dev.dart file) now explicitly exits the process to force completion of the parent task.

Tests:

  • n/a

Areas of Regression

  • n/a

Testing

  • CI build passes.

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@trentgrover-wf
Copy link
Contributor

+1

@codecov-io
Copy link

Current coverage is 52.11%

Merging #46 into master will not affect coverage as of d2690df

Powered by Codecov. Updated on successful CI builds.

@maxwellpeterson-wf
Copy link
Member

+1
@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title Explicitly exit process when dart_dev has finished CP-864 Explicitly exit process when dart_dev has finished Aug 20, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • CI passes running dart_dev tasks
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 20, 2015
CP-864 Explicitly exit process when dart_dev has finished
@jayudey-wf jayudey-wf merged commit d87790c into master Aug 20, 2015
@evanweible-wf evanweible-wf deleted the exit branch August 31, 2015 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants