Skip to content

Conversation

@evanweible-wf
Copy link
Contributor

Issue

#59

Changes

Source:

  • Need to add an await when running the "open" command after generating coverage report

Tests:

  • n/a

Areas of Regression

  • n/a

Testing

  • This is sort of hard to test, but on master you should see inconsistent behavior on whether or not the coverage report is automatically opened after generation.
  • With this change, the report should always open (as long as --open flag is set to true)

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@trentgrover-wf
Copy link
Contributor

+1

@codecov-io
Copy link

Current coverage is 48.05%

Merging #60 into master will not affect coverage as of 176d8a1

Powered by Codecov. Updated on successful CI builds.

@dustinlessard-wf
Copy link

+1

@jayudey-wf jayudey-wf changed the title Coverage: wait for "open" command CP-925 Coverage: wait for "open" command Aug 28, 2015
@maxwellpeterson-wf
Copy link
Member

+1

@evanweible-wf
Copy link
Contributor Author

@jayudey-wf ready for merge

@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • verified that when running with open flag the html page is opened by default
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 31, 2015
CP-925 Coverage: wait for "open" command
@jayudey-wf jayudey-wf merged commit acafb2c into master Aug 31, 2015
@evanweible-wf evanweible-wf deleted the coverage-open-wait branch August 31, 2015 15:41
@jayudey-wf
Copy link
Contributor

@Rosie run_merge_script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants