CP-958 Prevent pub serve errors from examples task #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix #52
Currently if
pub servehas any output on stderr during the examples task, it will cause the dart_dev process to exit. This happens any time there is a dart2js warning, or even a 404 (even for favicon.ico!)Changes
Source:
Areas of Regression
Testing
pub run dart_dev examples@trentgrover-wf
@evanweible-wf
@dustinlessard-wf
FYI @jayudey-wf