Skip to content

CP-1063 Running coverage on non_test dart files #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2015
Merged

CP-1063 Running coverage on non_test dart files #78

merged 1 commit into from
Oct 12, 2015

Conversation

@jayudey-wf
Copy link
Contributor

@jayudey-wf jayudey-wf commented Oct 8, 2015

Issue

Changes

Source:

  • Updated file check to just verify that file being passed in is a .dart file

Tests:

  • Added test to verify updated functionality

Areas of Regression

  • Coverage

Testing

  • Passing CI
  • That coverage will work when a non_test dart file is specified.

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@evanweible-wf
@dustinlessard-wf

@codecov-io
Copy link

codecov-io commented Oct 8, 2015

Current coverage is 48.05%

Merging #78 into master will not affect coverage as of 8f3fde3

Powered by Codecov. Updated on successful CI builds.

@trentgrover-wf
Copy link
Contributor

trentgrover-wf commented Oct 8, 2015

+1

evanweible-wf
evanweible-wf reviewed Oct 8, 2015
View reviewed changes
lib/src/tasks/coverage/api.dart Outdated
Copy link
Contributor

@evanweible-wf evanweible-wf Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_dartFilePattern would be consistent with _testFilePattern

@evanweible-wf
Copy link
Contributor

evanweible-wf commented Oct 8, 2015

+1 nice!

@jayudey-wf jayudey-wf force-pushed the non-test-file-coverage branch from 22bb149 to 9d0b9a3 Compare October 8, 2015 18:04
@jayudey-wf
Copy link
Contributor Author

jayudey-wf commented Oct 8, 2015

@evanweible-wf updated variable name

@evanweible-wf
Copy link
Contributor

evanweible-wf commented Oct 8, 2015

+1

@jayudey-wf jayudey-wf changed the title Running coverage on 'non_test' dart files Running coverage on non_test dart files Oct 12, 2015
@jayudey-wf jayudey-wf changed the title Running coverage on non_test dart files CP-1063 Running coverage on non_test dart files Oct 12, 2015
@jayudey-wf
Copy link
Contributor Author

jayudey-wf commented Oct 12, 2015

QA +10

  • installed into luxEditor and verified that coverage could be run on a non_test file

@jayudey-wf
Copy link
Contributor Author

jayudey-wf commented Oct 12, 2015

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • see comment above
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Oct 12, 2015
@jayudey-wf
Merge pull request #78 from Workiva/non-test-file-coverage
6dbe1c8 
CP-1063 Running coverage on non_test dart files
@jayudey-wf jayudey-wf merged commit 6dbe1c8 into master Oct 12, 2015
@evanweible-wf evanweible-wf mentioned this pull request Oct 14, 2015
Closed
@jayudey-wf jayudey-wf mentioned this pull request Oct 15, 2015
Merged
@evanweible-wf evanweible-wf deleted the non-test-file-coverage branch November 24, 2015 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jayudey-wf @codecov-io @trentgrover-wf @evanweible-wf