Skip to content

Conversation

@maxwellpeterson-wf
Copy link
Member

Issue

If consumers currently want to use a version of dartdoc newer than 0.4.0 alongside dart_dev, they'll need a dependency override

Changes

Source:

  • Relax the dartdoc dependency range to include any version between 0.4.0 and 0.9.0

Tests:

  • Update docs integration test to include the same version range.

Areas of Regression

  • Doc generation

Testing

  • Integration tests pass

Code Review

@trentgrover-wf
@evanweible-wf
@dustinlessard-wf
FYI @jayudey-wf

@dustinlessard-wf
Copy link

+1

@trentgrover-wf
Copy link
Contributor

+1
@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title Upgrade dartdoc dependency range CP-1102 Upgrade dartdoc dependency range Nov 11, 2015
@codecov-io
Copy link

Current coverage is 48.05%

Merging #90 into master will not affect coverage as of c6f53a7

Powered by Codecov. Updated on successful CI builds.

@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI build
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Nov 11, 2015
CP-1102 Upgrade dartdoc dependency range
@jayudey-wf jayudey-wf merged commit 0963e61 into master Nov 11, 2015
@evanweible-wf evanweible-wf deleted the update-dartdoc branch November 24, 2015 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants