RM-25125 Fixes #187: Update to the new go.uuid API #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmconsole-wf
changed the title
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
Collaborator
|
@iancmcc It looks like our travis build is still pulling in an old version of uuid, could you update that version so the tests pass? |
rsc
added a commit
to rsc/go-datastructures
that referenced
this pull request
May 25, 2018
The only call was uuid.NewV4().Bytes(), which really means "get me 16 random bytes". uuid.NewV4 changed at some point to return an error in addition to the UUID, which made this code no longer compile. There's no need to depend on a uuid package to get 16 random bytes. Do what the old package did, namely read from crypto/rand.Reader and expect it to succeed (or else panic), but without the dependency. Fixes Workiva#187. Fixes Workiva#188.
Contributor
|
I sent replacement PR #192, which removes go.uuid entirely. Then it doesn't matter what Travis is supplying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187. May or may not be worthwhile to merge this until it's clear whether or not the
breaking change upstream will be reverted. Hopefully if it's reverted it's done
in a backward-compatible way for those who already worked around it, if
possible.