Skip to content

Added lock to protect the RNG. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2015
Merged

Added lock to protect the RNG. #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions slice/skip/skip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ package skip

import (
"math/rand"
"sync"
"time"
)

Expand All @@ -76,8 +77,13 @@ const p = .5 // the p level defines the probability that a node
// randomly seeded generator.
var generator = rand.New(rand.NewSource(time.Now().UnixNano()))

// rnLock protects the RNG as the generator is not threadsafe.
var rnLock sync.Mutex

func generateLevel(maxLevel uint8) uint8 {
var level uint8
rnLock.Lock()
defer rnLock.Unlock()
for level = uint8(1); level < maxLevel-1; level++ {
if generator.Float64() >= p {
return level
Expand Down