Btrees with skiplists #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: slice/skip/skip.go
|
+1 |
2 similar comments
Contributor
|
+1 |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODE REVIEW
Integrated skiplist into B-PALM in an effort to increase performance when dealing with wider nodes. Over the standard B+ tree we show about a 3x increase in performance when doing bulk updates. A lot of that is now bottlenecked behind the random number generation, so we'll likely need to get a pool of generators in that package so hopefully we can increase availability. We are also getting caught behind the Compare call.
Not entirely thrilled with requiring a skip package interface in the PALM definition, so I'll probably do as @alexandercampbell-wf suggested and make a generic Comparator interface for the whole repo.
@alexandercampbell-wf @beaulyddon-wf @tannermiller-wf @ericolson-wf @stevenosborne-wf @tylertreat-wf @rosshendrickson-wf