Fixed potential issue on single core machine. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
I don't understand why this works. Can you explain?
Either way, it would be nice to wrap our NumCPU() calls in some utility function that would do this for us.
Contributor
Author
There was a problem hiding this comment.
We're just checking to see if there are an odd number of CPUs. In most cases a user will have 1, 2 and then some multiple of 2 thereafter. If someone intentionally disabled a CPU to get an odd number (someone who has more than one core) this will also even that out.
Contributor
There was a problem hiding this comment.
Yeah, and AMD at least went through a phase where they sold triple-core processors. I actually have one at home in my desktop; fourth core unlocked and overclocked of course 😄
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
dustinhiatt-wf
added a commit
that referenced
this pull request
Feb 10, 2015
Fixed potential issue on single core machine.
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODE REVIEW
Fixes potential issue on single core machines.
@alexandercampbell-wf @beaulyddon-wf @tannermiller-wf @ericolson-wf @stevenosborne-wf @tylertreat-wf @rosshendrickson-wf