Ring buffer #59
Merged
Ring buffer #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 lockless datastructures are very cool |
Contributor
|
+1 |
|
Awesome. +1 |
Contributor
There was a problem hiding this comment.
Alignment is a little off here.
Contributor
There was a problem hiding this comment.
The benchmarking does this for some reason. Pretty annoying.
Contributor
|
Super minor. +1 |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODE REVIEW
We have buffers in our codebase that are protected with locks and waitgroups for blocking. We need a faster buffer and this is that. This is an MPMC threadsafe ring buffer where threadsafety is achieved using only CAS operations. Makes this buffer pretty fast, and the fixed size ensures bounded sorts of behavior. Calling dispose on this buffer will free any blocked threads with an error returned (unlike panicking with channels).
I'm hoping to use this to speed up the PALM tree.
BenchmarkRBLifeCycle-8 10000000 177 ns/op // involves simultaneous put/get of b.N items
BenchmarkRBPut-8 30000000 58.1 ns/op
BenchmarkRBGet-8 50000000 26.8 ns/op
@alexandercampbell-wf @beaulyddon-wf @tannermiller-wf @rosshendrickson-wf @tylertreat-wf @ericolson-wf @stevenosborne-wf