Skip to content

Conversation

@alexandercampbell-wk
Copy link
Contributor

Code Review

Testify (our testing framework) made some breaking changes and tests were showing failures of the form

0x0 != 0
0x7 != 7
0x5 != 5

and so on. This was caused by a type mismatch: int64 != int and so on. Fix these broken tests by adding explicit type annotations to our calls of assert.Equal()

Reviewers

@dustinhiatt-wf @tannermiller-wf @beaulyddon-wf @stevenosborne-wf @tylertreat-wf

@tannermiller-wf
Copy link
Contributor

+1

@dustinhiatt-wf
Copy link
Contributor

+1

@stevenosborne-wf
Copy link
Contributor

+1

@alexandercampbell-wk
Copy link
Contributor Author

@dustinhiatt-wf are you okay with alexandercampbell-wk@6034e86 ?

@dustinhiatt-wf
Copy link
Contributor

@alexandercampbell-wf, yeah, going to get back and make the corrections not noted in the paper as soon as possible :).

alexandercampbell-wk added a commit that referenced this pull request Feb 11, 2015
@alexandercampbell-wk alexandercampbell-wk merged commit 9782481 into Workiva:master Feb 11, 2015
@alexandercampbell-wk alexandercampbell-wk deleted the update_testify_failures branch February 11, 2015 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants