Misc readme #64
Merged
Misc readme #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrapped the long lines to 80 characters to be consistent with the way we do block comments in the code. I don't feel strongly about this either way and I'd be fine with reverting the change.
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Review
Miscellaneous fixes in the README. Update the package comment for the root package so
godoc github.com/Workiva/go-datastructuresis more helpful.I wrapped the long lines in the README to be consistent with our other projects and the block comments in the code. I don't feel strongly about this-- if we decide to revert it, that's totally fine.
Reviewers
@dustinhiatt-wf @tannermiller-wf @beaulyddon-wf @stevenosborne-wf