Fix warnings by hand

Author: greglittlefield-wf

example/test/function_component_test.dart

@@ -467,7 +467,7 @@ UseImperativeHandleTestComponent2(Map props) {
 
 class ChatAPI {
   static void subscribeToFriendStatus(int id, Function handleStatusChange) =>
-      handleStatusChange({'isOnline': id % 2 == 0 ? true : false});
+      handleStatusChange({'isOnline': id % 2 == 0});
 
   static void unsubscribeFromFriendStatus(int id, Function handleStatusChange) =>
       handleStatusChange({'isOnline': false});

lib/react_client/component_factory.dart

@@ -87,9 +87,8 @@ class ReactDartComponentFactoryProxy<TComponent extends Component> extends React
   /// into [generateExtendedJsProps] upon [ReactElement] creation.
   final Map defaultProps;
 
-  ReactDartComponentFactoryProxy(ReactClass reactClass)
-      : reactClass = reactClass,
-        defaultProps = reactClass.dartDefaultProps;
+  ReactDartComponentFactoryProxy(this.reactClass)
+      : defaultProps = reactClass.dartDefaultProps;
 
   @override
   ReactClass get type => reactClass;
@@ -182,9 +181,8 @@ class ReactDartComponentFactoryProxy2<TComponent extends Component2> extends Rea
   @override
   final Map defaultProps;
 
-  ReactDartComponentFactoryProxy2(ReactClass reactClass)
-      : reactClass = reactClass,
-        defaultProps = JsBackedMap.fromJs(reactClass.defaultProps);
+  ReactDartComponentFactoryProxy2(this.reactClass)
+      : defaultProps = JsBackedMap.fromJs(reactClass.defaultProps);
 
   @override
   ReactClass get type => reactClass;

lib/react_client/react_interop.dart

@@ -1,4 +1,3 @@
-// ignore_for_file: deprecated_member_use_from_same_package
 /// JS interop classes for main React JS APIs and react-dart internals.
 ///
 /// For use in `react_client.dart` and by advanced react-dart users.
@@ -855,10 +854,10 @@ class JsComponentConfig {
 @anonymous
 class JsComponentConfig2 {
   external factory JsComponentConfig2({
+    @required List<String> skipMethods,
     dynamic contextType,
     JsMap defaultProps,
     JsMap propTypes,
-    @required List<String> skipMethods,
   });
 }
 
@@ -874,5 +873,5 @@ class ReactErrorInfo {
 
   /// The dart stack trace associated with this error.
   external StackTrace get dartStackTrace;
-  external set dartStackTrace(StackTrace);
+  external set dartStackTrace(StackTrace value);
 }

test/factory/common_factory_tests.dart

@@ -405,7 +405,6 @@ void refTests<T>(
     test('string refs', () {
       final renderedInstance = _renderWithStringRefSupportingOwner(() => factory({'ref': 'test'}));
 
-      // ignore: deprecated_member_use_from_same_package
       verifyRefValue(renderedInstance.dartComponent.ref('test'));
     });
   });
@@ -645,9 +644,7 @@ class EventTestCase {
         description = 'JS handler $description';
 
   String get _camelCaseEventName {
-    var name = eventPropKey.replaceFirst(RegExp(r'^on'), '');
-    name = name.substring(0, 1).toLowerCase() + name.substring(1);
-    return name;
+    return eventPropKey.replaceFirst(RegExp(r'^on'), '').capitalize();
   }
 
   void simulate(Element node) => callMethod(_Simulate, _camelCaseEventName, [node]);
@@ -656,5 +653,9 @@ class EventTestCase {
   String toString() => 'EventHelper: ($eventPropKey) $description';
 }
 
+extension on String {
+  String capitalize() => substring(0, 1).toLowerCase() + substring(1);
+}
+
 @JS('React.addons.TestUtils.Simulate')
 external dynamic get _Simulate;

test/forward_ref_test.dart

@@ -13,7 +13,6 @@ import 'factory/common_factory_tests.dart';
 main() {
   group('forwardRef', () {
     group('- common factory behavior -', () {
-      // ignore: deprecated_member_use_from_same_package
       final ForwardRefTest = react.forwardRef((props, ref) {
         props['onDartRender']?.call(props);
         return react.div({...props, 'ref': ref});

test/lifecycle_test/component2.dart

@@ -220,7 +220,7 @@ class _ErrorComponent extends react.Component2 {
   }
 
   @override
-  void render() {
+  render() {
     _throwError();
     return react.div({'key': 'defaultMessage'}, 'Error');
   }

test/util.dart

@@ -124,7 +124,7 @@ class RefTestCaseCollection<T> {
     );
   }
 
-  RefTestCase createRefObjectCase<T>() {
+  RefTestCase createRefObjectCase() {
     const name = 'ref object';
     final ref = createRef<T>();
     return RefTestCase(
@@ -175,7 +175,7 @@ class RefTestCaseCollection<T> {
         createJsRefObjectCase(),
       ];
 
-  RefTestCase createCaseByName<T>(String name) => createAllCases().singleWhere((c) => c.name == name);
+  RefTestCase createCaseByName(String name) => createAllCases().singleWhere((c) => c.name == name);
 
   List<String> get allTestCaseNames => createAllCases().map((c) => c.name).toList();
 }