dart fix --apply --code=prefer_final_in_for_each

Author: greglittlefield-wf

example/test/react_test_components.dart

@@ -168,7 +168,7 @@ class _ListComponent extends react.Component {
   @override
   dynamic render() {
     List<dynamic> items = [];
-    for (var item in state['items']) {
+    for (final item in state['items']) {
       items.add(react.li({'key': item}, '$item'));
     }
 
@@ -473,7 +473,7 @@ class _Component2TestComponent extends react.Component2 with react.TypedSnapshot
     // Used to generate unique keys even when the list contains duplicate items
     final itemCounts = <dynamic, int>{};
     final items = [];
-    for (var item in state['items']) {
+    for (final item in state['items']) {
       final count = itemCounts[item] = (itemCounts[item] ?? 0) + 1;
       items.add(react.li({'key': 'c2-$item-$count'}, '$item'));
     }

example/test/speed_test.dart

@@ -55,7 +55,7 @@ class _Hello extends react.Component {
     timeprint('rendering start');
     var data = props['data'];
     var children = [];
-    for (var elem in data) {
+    for (final elem in data) {
       children.add(react.div({
         'key': elem[0]
       }, [

lib/react_client/js_backed_map.dart

@@ -79,7 +79,7 @@ class JsBackedMap extends MapBase<dynamic, dynamic> {
 
   @override
   void clear() {
-    for (var key in _keys) {
+    for (final key in _keys) {
       _Reflect.deleteProperty(jsObject, key);
     }
   }

lib/react_client/js_interop_helpers.dart

@@ -100,7 +100,7 @@ _convertDataTree(data) {
     if (o is Map) {
       final convertedMap = newObject();
       _convertedObjects[o] = convertedMap;
-      for (var key in o.keys) {
+      for (final key in o.keys) {
         setProperty(convertedMap, key, _convert(o[key]));
       }
       return convertedMap;

lib/react_client/react_interop.dart

@@ -243,7 +243,7 @@ ReactJsComponentFactoryProxy forwardRef(
 }) {
   final wrappedComponent = allowInterop((JsMap props, JsRef ref) => componentZone.run(() {
         final dartProps = JsBackedMap.backedBy(props);
-        for (var value in dartProps.values) {
+        for (final value in dartProps.values) {
           if (value is Function) {
             // Tag functions that came straight from the JS
             // so that we know to pass them through as-is during prop conversion.

lib/src/react_client/event_prop_key_to_event_factory.dart

@@ -80,7 +80,7 @@ final Set<String> knownEventKeys = (() {
   };
 
   // Add support for capturing variants; e.g., onClick/onClickCapture
-  for (var key in _knownEventKeys.toList()) {
+  for (final key in _knownEventKeys.toList()) {
     _knownEventKeys.add(key + 'Capture');
   }
 

test/factory/common_factory_tests.dart

@@ -263,7 +263,7 @@ void domEventHandlerWrappingTests(ReactComponentFactoryProxy factory) {
     });
 
     group('passing Dart events to Dart handlers, and JS events to handlers originating from JS:', () {
-      for (var eventCase in eventCases) {
+      for (final eventCase in eventCases) {
         test(eventCase.description, () {
           eventCase.simulate(node);
           expect(events[eventCase], isNotNull, reason: 'handler should have been called');
@@ -289,7 +289,7 @@ void domEventHandlerWrappingTests(ReactComponentFactoryProxy factory) {
 
         final dummyEvent = event;
 
-        for (var eventCase in eventCases.where((helper) => helper.isDart)) {
+        for (final eventCase in eventCases.where((helper) => helper.isDart)) {
           test(eventCase.description, () {
             expect(() => propsFromDartRender[eventCase.eventPropKey](dummyEvent), returnsNormally);
           });