Skip to content

Clarification on fx/fy and h/w pairing in gaussians_renderer.py #9

@houstonwhy

Description

@houstonwhy

Dear Prometheus Team,

Thank you for your excellent work — I am very interested in reproducing your results. While reviewing prometheus/modules/renderers/gaussians_renderer.py, I noticed what appears to be an inconsistency in how the focal lengths are paired with image dimensions. In "convert_camera_parameters_into_viewpoint_cameras" and in the MiniCam class, the variable named fx is scaled with the image height (h), and fy is scaled with the image width (w). However, inside the "render" method the intrinsic matrix is reconstructed with focal_length_x derived from the image width and FoVx. This seems to swap the associations compared with the earlier steps.

Could you please clarify whether this behavior is intentional, or if there is a mix-up in the conventions that should be corrected? Any guidance you can provide would be greatly appreciated.

Thank you for your time and support.

Best regards,
Haoyu

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions