-
Notifications
You must be signed in to change notification settings - Fork 2
Fix recommended security vulnerabilities and upgrade lerna to v8.2.2 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI be careful with lerna upgrades - one lerna upgrade on xrpl.js made us unable to publish new versions |
@mvadari I was thinking of testing the lerna version update change by releasing |
@Patel-Raj11 that's probably the best way. Glad you're testing - the last time we tried major-upgrading Lerna (from 4.x to 6.x on the JS repos IIRC) we weren't able to release later 😬 |
Upgraded lerna to v8.2.2 and followed the changelog to fix breaking changes if any for both v7.0.0 and v8.0.0. Ran
npx lerna repair
as suggested in changelog.Ran
npm audit fix
to fix the recommended security vulnerabilities from semgrepFixed test.yml workflow to use actions/setup-node@v4 and actions/checkout@v4 actions and default to Node 18 while running the tests and only execute on pull requests, merge to master and manually trigger.
Output:
run
npm fund
for detailsfound 0 vulnerabilities