Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [[Unreleased]]

## [[4.3.1]] - 2025-11-12

### Added

- Add `encode_mptoken_metadata` and `decode_mptoken_metadata` helper functions to encode and decode MPTokenMetadata as per XLS-89 standard.
Expand All @@ -16,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Removed snippets files from the xrpl-py code repository. Updated the README file to point to the correct location on XRPL.org.
- [Breaking change] Fix `MPTokenMetadata` type to adhere to the XLS-89 standard. Since XLS-89 is still in a forming state and undergoing changes, this breaking change is being released as a bug fix via patch version bump. If you are using `MPTokenMetadata` in your code, please verify that it adheres to the updated type definition.
- [Breaking change] Fix `validate_mptoken_metadata` to correctly validate MPTokenMetadata as per XLS-89 standard. Since XLS-89 is still in a forming state and undergoing changes, this breaking change is being released as a bug fix via patch version bump. If you are using `validateMPTokenMetadata` in your code, expect it to change as per the XLS-89 standard.
- Fixed the binary-codec issues pertaining to the serialization of the `MPTCurrency` rippled type. (Reference PR: https://github.com/XRPLF/xrpl-py/pull/870)
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Wrap the bare URL in markdown link syntax.

Line 21 contains a bare URL that should be wrapped in proper markdown link format to comply with markdown best practices.

Apply this diff to fix the formatting:

-- Fixed the binary-codec issues pertaining to the serialization of the `MPTCurrency` rippled type. (Reference PR: https://github.com/XRPLF/xrpl-py/pull/870)
+- Fixed the binary-codec issues pertaining to the serialization of the `MPTCurrency` rippled type. ([Reference PR](https://github.com/XRPLF/xrpl-py/pull/870))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Fixed the binary-codec issues pertaining to the serialization of the `MPTCurrency` rippled type. (Reference PR: https://github.com/XRPLF/xrpl-py/pull/870)
- Fixed the binary-codec issues pertaining to the serialization of the `MPTCurrency` rippled type. ([Reference PR](https://github.com/XRPLF/xrpl-py/pull/870))
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

21-21: Bare URL used

(MD034, no-bare-urls)

🤖 Prompt for AI Agents
In CHANGELOG.md around line 21, the PR reference is a bare URL; wrap it in
markdown link syntax so it displays as a proper link. Replace the bare URL with
a markdown link like [PR #870](https://github.com/XRPLF/xrpl-py/pull/870) (or
similar descriptive text) so the changelog uses proper markdown link formatting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a critical suggestion. I will choose to ignore it for the paucity of time. We need to release this library to bring parity between the different programming languages client libraries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckeshava, understood! No problem at all—I appreciate you prioritizing the release timeline. Best of luck with getting 4.3.1 out the door! 🚀


🧠 Learnings used
Learnt from: ckeshava
Repo: XRPLF/xrpl-py PR: 866
File: xrpl/models/transactions/loan_set.py:158-181
Timestamp: 2025-09-15T15:54:25.836Z
Learning: In the xrpl-py codebase, validation logic for transaction fields is primarily handled by rippled (the C++ XRPL implementation) rather than being duplicated in the Python models. Python models should focus on basic structural validation rather than comprehensive field validation that rippled already performs.

Learnt from: mvadari
Repo: XRPLF/xrpl-py PR: 759
File: tests/unit/models/transactions/test_account_delete.py:52-60
Timestamp: 2024-12-12T00:48:38.042Z
Learning: The credential ID format validation for xrpl-py is being tracked in issue #766 and should not be duplicated in other PRs.


## [[4.3.0]] - 2025-07-29

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "xrpl-py"
version = "4.3.0"
version = "4.3.1"
description = "A complete Python library for interacting with the XRP ledger"
license = "ISC"
readme = "README.md"
Expand Down