Skip to content

feat: require Signed-off-by in commit messages#785

Merged
Xe merged 2 commits intomasterfrom
Xe/require-signoff-commit-msg-hook
Nov 14, 2025
Merged

feat: require Signed-off-by in commit messages#785
Xe merged 2 commits intomasterfrom
Xe/require-signoff-commit-msg-hook

Conversation

@Xe
Copy link
Owner

@Xe Xe commented Nov 14, 2025

Summary

  • Add signoff validation to commit-msg hook
  • Reject commits without Signed-off-by line
  • Provide helpful error message directing users to use --signoff
  • Maintains existing [skip ci] functionality

Changes

  • Modified .husky/commit-msg to check for Signed-off-by: lines before allowing commits
  • Added clear error messaging when signoff is missing
  • Hook now exits with error code 1 if no signoff is found
  • Preserves all existing commitlint and test functionality

Test plan

  • Verify hook rejects commits without signoff
  • Verify hook accepts commits with signoff
  • Verify [skip ci] flag still works while requiring signoff
  • Test that commit-msg hook is executable and functional

Xe added 2 commits November 14, 2025 15:08
- Add signoff validation to commit-msg hook
- Reject commits without Signed-off-by line
- Provide helpful error message directing users to use --signoff
- Maintains existing [skip ci] functionality

Assisted-by: GLM 4.6 via Claude Code
Signed-off-by: Xe Iaso <me@xeiaso.net>
@Xe Xe enabled auto-merge (squash) November 14, 2025 20:08
@github-actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Go / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 14, 2025, 8:10 PM

@Xe Xe merged commit 7e1c910 into master Nov 14, 2025
7 checks passed
Xe pushed a commit that referenced this pull request Jan 8, 2026
# [1.27.0](v1.26.1...v1.27.0) (2026-01-08)

### Bug Fixes

* **package.json:** use Signed-off-by instead of Signed-Off-By ([c2406e3](c2406e3))
* **yeetfile:** build sysexts ([c9b3ab7](c9b3ab7))

### Features

* add 7-day cooldown to dependabot updates ([#791](#791)) ([1a5d9d3](1a5d9d3))
* add attention attenuator package ([6ca9c01](6ca9c01))
* add claude-code-cfg package ([73798a3](73798a3))
* **kube/alrest:** add mcp-auth sidecar ([e56238b](e56238b))
* **mi:** add birthday field to Member model ([#784](#784)) ([69bff8e](69bff8e))
* require Signed-off-by in commit messages ([#785](#785)) ([7e1c910](7e1c910))

Signed-off-by: Mimi Yasomi <mimi@techaro.lol>
@Xe
Copy link
Owner Author

Xe commented Jan 8, 2026

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Xe Xe added the released label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant