Payslip - Invalid value for `calculation_type`, must not be `None

[commit4ever]

Hi

With version 1.0.5 when we retrieving a payslip using the get_payslip function for a Demo company

https://api.xero.com:443 "GET /payroll.xro/1.0/Payslip/{a valid payslip id}
we get the exception

---

File "/home/ubuntu/..... /lib/python3.7/site-packages/xero_python/payrollau/models/earnings_line.py", line 146, in calculation_type
"Invalid value for calculation_type, must not be None"
ValueError: Invalid value for calculation_type, must not be `None

---

This error comes for a valid payrun id with valid payslips that have been posted in the Xero APP.

Can you tell us why ? Is there a specific configuration that is needed in Xero-->Settings--> Payroll settings ?

Regards
Cee

[SidneyAllen]

@aiseei - Thank you for reporting this.

I've removed calculationType as a required property on Earning Lines in version 1.0.7.

Cheers

[SoSDylan]

This issue has seemed to pop up for me too, I'm using version xero-python 1.3.0.

It gets thrown when trying to call payrollau_api.get_employee(xero_tenant_id, employee_id) with ceartain employee_id's.

  File "/Users/Dylan/Desktop/CrewTraka/CrewTraka-Web/backend/api/services/xero_service.py", line 142, in payroll_get_employee
    read_employees = payrollau_api.get_employee(xero_tenant_id, employee_id)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/payrollau/api/payroll_au_api.py", line 668, in get_employee
    return self.api_client.call_api(
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/__init__.py", line 350, in call_api
    return self.__call_api(
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/__init__.py", line 213, in __call_api
    return_data = self.deserialize(
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/__init__.py", line 246, in deserialize
    return deserialize(response_type, data, response_model_finder)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/single_dispatch_str.py", line 90, in wrapper
    return dispatch(key)(*args, **kw)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 58, in deserialize
    return deserialize_model(model, data, model_finder)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 281, in deserialize_model
    kwargs[attr] = deserialize(attr_type, value, model_finder)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/single_dispatch_str.py", line 90, in wrapper
    return dispatch(key)(*args, **kw)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 77, in deserialize_list
    return [deserialize(sub_data_type, sub_data, model_finder) for sub_data in data]
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 77, in <listcomp>
    return [deserialize(sub_data_type, sub_data, model_finder) for sub_data in data]
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/single_dispatch_str.py", line 90, in wrapper
    return dispatch(key)(*args, **kw)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 58, in deserialize
    return deserialize_model(model, data, model_finder)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 281, in deserialize_model
    kwargs[attr] = deserialize(attr_type, value, model_finder)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/single_dispatch_str.py", line 90, in wrapper
    return dispatch(key)(*args, **kw)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 58, in deserialize
    return deserialize_model(model, data, model_finder)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 281, in deserialize_model
    kwargs[attr] = deserialize(attr_type, value, model_finder)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/single_dispatch_str.py", line 90, in wrapper
    return dispatch(key)(*args, **kw)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 77, in deserialize_list
    return [deserialize(sub_data_type, sub_data, model_finder) for sub_data in data]
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 77, in <listcomp>
    return [deserialize(sub_data_type, sub_data, model_finder) for sub_data in data]
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/single_dispatch_str.py", line 90, in wrapper
    return dispatch(key)(*args, **kw)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 58, in deserialize
    return deserialize_model(model, data, model_finder)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/api_client/deserializer.py", line 283, in deserialize_model
    instance = model(**kwargs)
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/payrollau/models/deduction_line.py", line 66, in __init__
    self.calculation_type = calculation_type
  File "/Users/Dylan/.local/share/virtualenvs/backend-ZTo9M3Up/lib/python3.9/site-packages/xero_python/payrollau/models/deduction_line.py", line 120, in calculation_type
    raise ValueError(
ValueError: Invalid value for `calculation_type`, must not be `None`

[NateJones5150]

Hi team - I'm getting the same issue as above for payrollau_api.get_employee when limiting for a specific employee id. Has this been addressed in the latest version?