-
Notifications
You must be signed in to change notification settings - Fork 58
Open
Description
Changing ordering of signature params like this is a surefire recipe for disaster:
https://github.com/XeroAPI/xero-python/blame/master/xero_python/accounting/models/contacts.py#L36
Introduced in 25a6d3e:

Where Contacts([Contact(...)]) would before create a Contacts instance with a single Contact, it now assigns that list to pagination...
That's a breaking change that's hard for consumers to track.
Recommendation: disallow positional params, require kwargs only:
def __init__(self, pagination=None, contacts=None):
->
def __init__(self, *, pagination=None, contacts=None):
Metadata
Metadata
Assignees
Labels
No labels