Allow id_token to be optional for OAuth2Token.update_token #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not omitted when the "openid" scope is not used Signed-off-by: Santiago Romero <santiago@gourmetgrowth.com>
SidneyAllen
added a commit
that referenced
this pull request
Nov 3, 2020
ACCOUNTING Add specs for the Organisation endpoint subresource Action Add two components Actions and Action BatchPaymentDetails remove max length from Details property Adding History for Manual Journals Rename two problem currencies to TRY_LIRA and EMPTY_CURRENCY AU PAYROLL Add Timesheet Status enum REJECTED and REQUESTED NZ PAYROLL fix casing on tag for PayrollNZ …should be PayrollNz Merge PR changes #28
Contributor
|
@sromero84 thanks for the PR, I've merged the change in version 1.0.13 |
Author
|
@SidneyAllen Awesome, thanks! Updating our code at Gourmet Growth as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
The "id_token" key is not present when the the
openidscope is not used. This especially problematic when migration from OAuth1, since theopenidscope is not allowed during the migration.