[AIEX] Support simple Tail Call Opt #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It would be nice to have a description of the tail call strategy. It's intricate management of the stack, We need to setup arguments to the tail callee, we need to restore the callee saved registers, I would like to know what determines whether something is a tail call, do we try to free up as much stack as possible, etc. |
krishnamtibrewala
force-pushed
the
aie-tail-call
branch
3 times, most recently
from
c0cb1e2 to
199ba27
Compare
krishnamtibrewala
changed the title
krishnamtibrewala
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto and
stephenneuendorffer
as code owners
llvm/test/CodeGen/AIE/aie2/GlobalISel/prologepilog-tail-call-opt.ll
Outdated
Show resolved
Hide resolved
llvm/test/CodeGen/AIE/aie2p/GlobalIsel/prologepilog-tail-call-opt.ll
Outdated
Show resolved
Hide resolved
krishnamtibrewala
force-pushed
the
aie-tail-call
branch
from
199ba27 to
e2505bc
Compare
konstantinschwarz
approved these changes
Apr 8, 2025
Collaborator
konstantinschwarz
left a comment
konstantinschwarz
left a comment
There was a problem hiding this comment.
Nice, thanks for applying all comments.
I think this looks good as an initial version of tail call optimization.
Handling more complicated scenarios can come as follow-up work.
mgehre-amd
pushed a commit
that referenced
this pull request
Aug 21, 2025
[AutoBump] Merge with 8280651 (Sep 17) (5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.