Skip to content

[TOSA] Extend folding/canonicalization for concat, tile and slice. #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 14, 2025
Merged

[TOSA] Extend folding/canonicalization for concat, tile and slice. #486

merged 6 commits into from
Mar 14, 2025

Conversation

@jorickert
Copy link

@jorickert jorickert commented Mar 11, 2025 •
edited
Loading

  • Downstream changes
  • Simplify concat slice pattern
  • Test with zero size inputs

I plan to upstream this, likely after the tosa dialect changes

@jorickert jorickert changed the title [TOSA] Extend folding/canonicaliation for concat, tile and slice. [TOSA] Extend folding/canonicalization for concat, tile and slice. Mar 11, 2025
@jorickert jorickert force-pushed the jrickert.fold_concat branch from 010bbd6 to 72ce6e7 Compare March 11, 2025 17:39
@jorickert jorickert marked this pull request as draft March 12, 2025 07:32
mgehre-amd
mgehre-amd reviewed Mar 12, 2025
View reviewed changes
mgehre-amd
mgehre-amd reviewed Mar 12, 2025
View reviewed changes
@jorickert jorickert force-pushed the jrickert.fold_concat branch from 55ced7f to bf62f7a Compare March 12, 2025 13:17
jorickert
jorickert commented Mar 12, 2025
View reviewed changes
@jorickert jorickert requested a review from mgehre-amd March 12, 2025 13:19
@jorickert jorickert marked this pull request as ready for review March 12, 2025 13:19
ttjost
ttjost reviewed Mar 12, 2025
View reviewed changes
@ehsan-toosi ehsan-toosi removed their request for review March 12, 2025 14:46
jorickert
jorickert commented Mar 12, 2025
View reviewed changes
ttjost
ttjost reviewed Mar 12, 2025
View reviewed changes
roberteg16
roberteg16 reviewed Mar 12, 2025
View reviewed changes
@jorickert jorickert force-pushed the jrickert.fold_concat branch from b5989ce to b79648d Compare March 12, 2025 15:06
roberteg16
roberteg16 reviewed Mar 12, 2025
View reviewed changes
@jorickert jorickert force-pushed the jrickert.fold_concat branch from b79648d to 81059fb Compare March 12, 2025 15:26
@jorickert jorickert requested review from roberteg16 and ttjost March 12, 2025 15:26
roberteg16
roberteg16 approved these changes Mar 12, 2025
View reviewed changes
Copy link

@roberteg16 roberteg16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look very nice!

@jorickert jorickert force-pushed the jrickert.fold_concat branch from 81059fb to b87be4f Compare March 12, 2025 16:57
@jorickert jorickert merged commit 8859aa8 into feature/fused-ops Mar 14, 2025
4 checks passed
@jorickert jorickert deleted the jrickert.fold_concat branch March 14, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberteg16 roberteg16 roberteg16 approved these changes

@mgehre-amd mgehre-amd mgehre-amd approved these changes

@ttjost ttjost Awaiting requested review from ttjost

Assignees

No one assigned

Labels

upstream

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jorickert @ttjost @roberteg16 @mgehre-amd