[AutoBump] Merge with fixes of 09dfc571 (Dec 20) (26) [Only tested MLIR] #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been in the original commit, but I somehow forgot to run git add && git commit --amend --no-edit between making the change in my editor, saving the file, and pushing the commit.
…121006) Linking this runtime requires C++ ABI, which breaks -nostdlib++ builds. However, UBSAN C++ runtime is only needed for CFI and VPTR checks. Unblocks llvm#120370.
Summary: We previously built this for every single architecture to deal with incompatibility. This patch updates it to use the 'generic' IR that `libc` and other projects use. Who knows if this will have any side-effects, probably worth testing more but it passes the tests I expect to pass on my side.
Implement GNU and MSVC variants. When using them, _WIN32 and _M_MRX000/_MIPS_ macros are correctly defined.
…0684) Adds release notes for the FUJITSU-MONAKA support introduced in PR llvm#118432. These notes were missing from the original PR.
Multiple prints will cause problems when testing ir-bb
…lvm#120685) Add a `valid-element-access` check to `valarray::operator[]` and `bitset::operator[]`.
HLASM is very different from the gas syntax. We don't expect other targets to customize the differences. Unify the numerous variables.
Fix build issue introduced in llvm#120547
…#120656) Vector::BroadCastOp expects the identical element type in folding. It causes the crash if the different source type is given to the SCCP pass. We need to guard the pass from crashing if the nonidentical element type is given, but still compatible. (e.g. index vs integer type) llvm#120193
It's should be enough to provide weak implementation. Fixes solaris and android linking after llvm#121006.
Broken by llvm#121006.
AIX assembly is very different from the gas syntax. We don't expect other targets to share these differences. Unify the numerous, essentially AIX-specific variables.
…#120907) Define the `LLVM_SHLIB_OUTPUT_INTDIR` variable that is used by `configure_lit_site_cfg` to fill `SHLIBDIR`. This fixes tool tests that would otherwise be unable to find MLIR's runtime shared libraries (e.g. `libmlir_runner_utils.so`). The logic is copied verbatim from Clang.
Fix the logic used to run unit tests to account for `llvm_gtest` targets being installed, since 91b3ca3. This involves removing a rule that would cause a duplicate `llvm_gtest` target being created, and updates the method for determining whether unittests can be run to checking whether the target is present, rather than the source directory (that is no longer actually necessary).
…lds (llvm#120911) Since LLVM tools are installed system-wide, adding dependencies on them is unnecessary. Furthermore, it is problematic for multilib builds, where the tools are only built once, for the native ABI, and therefore are not listed in CMake files for non-native ABIs.
There is no shared version RTUbsan_cxx. Fix android after llvm#121006.
Resolves llvm#114703 I think it's the best practice that each macro has it's own `ifndef` check and this way the build issue is resolved for me. I also find the names of these macro a bit too generic - an easy recipe for conflicts. In my case, the error was likely caused by something else defining `CHECK` but not `CHECK_MSG`, so likely these `CHECK` and `CHECK_MSG` weren't actually working at all because the result of `ifndef` is always false. As a definitive fix, perhaps it makes sense to rename them to something more specific, e.g. `FLANG_CHECK` and `FLANG_CHECK_MSG`.
Remove extra command line arguments while here.
This commit fixes some but not all memory leaks in Flang. There are still 91 tests that fail with ASAN. - Use `mlir::OwningOpRef` instead of `std::unique_ptr`. The latter does not free allocations of nested blocks. - Pass `ModuleOp` as value instead of reference. - Add few missing deallocations in test cases and other places.
This PR implements support for generic Xtensa target in CLang. Co-authored-by: Andrei Safronov <safronov@espressif.com>
…values (llvm#119774) After llvm#96127 landed, mshockwave reported that the pass was no longer threading SPEC2006/perlbench. After 96127 we started bailing out in `getStateDefMap` and rejecting the transformation because one of the unpredictable values was coming from inside the loop. There was no fundamental change in that function except that we started calling `Loop->contains(IncomingBB)` instead of `LoopBBs.count(IncomingBB)`. After some analysis I came to the conclusion that even before 96127 we would reject the transformation if we provided large enough limits on the path traversal (large enough so that LoopBBs contained blocks corresponding to that unpredictable value). In this patch I changed `getStateDefMap` to not terminate early on finding an unpredictable value, this is because `getPathsFromStateDefMap`, later, actually has checks to ensure that the final list of paths only have predictable values. As a result we can now partially thread functions like `negative6` in the tests that have some predictable paths. This patch does not really have any compile-time impact on the test suite without `-dfa-early-exit-heuristic=false` (early exit is enabled by default). Change-Id: Ie1633b370ed4a0eda8dea52650b40f6f66ef49a3
Close llvm#121066 Now we will diagnose that the import statement lacks a semicolon as expected. Note that the original "not found" diagnose message remains. I meant to remove that, but the test shows it might be more complex process (other unexpected diagnose shows up). Given the importance of the issue, I chose to not dig deeper.
…120988) Support the lowering of vectorized FMINIMUM and FMAXIMUM to vminph and vmaxph on types v8f16, v16f16 when AVX512FP, AVX512VL features are present, and on type v32f16 when AVX512FP is present.
An equivalent matcher under the name Optional has since been added upstream to GMock. Fixes llvm#121308
Commit edca1d9 enabled threaded linking by default in llvm-jitlink, but we need to handle the case where LLVM is built with -DLLVM_ENABLE_THREADS=Off. This patch updates the llvm-jitlink tool to switch back to materialization on the main thread (equivalent to llvm-jitlink -num-threads=0 ...) when LLVM is built without thread support.
This splits the shuffle-select CostModel test into a seperate CodeGen test and removes the codegen from the CostModel version. An extra fp16 test is added too.
…nge checking. NFC
…#121462) When emitting diagnostics for the number of elements.
A Phase Ordering test for intrinsic shuffles is also added, showing a recent regression from vector combining.
We were passing size in bytes for the sizeInBits field in DIDerivedTypeAttr with DW_TAG_pointer_type. Although this field is un-used in this case but better to be accurate.
…lvm#118940) Switch from rewrite patterns to conversion patterns. This allows to perform type conversions together with other parts of the IR. For example, this allows to convert from index to emit.size_t types.
… EmitC (llvm#118940)" This reverts commit 450c6b0.
…119419) The fcmp + fadd + sel => fcmp + sel + fadd xfrm performs incorrect transformation when select branch values are swapped. This change fixes this.
…#121339) ARM64EC and ARM64X images require a load configuration to be valid.
Split off from llvm#108378. This ensures that the logic works even if now vector region exits.
…hildParameters (llvm#121033) This was never set to anything other than `true`.
Address comment at llvm#121373 (comment)
[AutoBump] Merge with 4b22ef7 (Jan 02) (27) [Only tested MLIR]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.