Skip to content

Niklas.variable naming #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 16, 2025
Merged

Niklas.variable naming #529

merged 19 commits into from
Apr 16, 2025

Conversation

@ndegener-amd
Copy link

@ndegener-amd ndegener-amd commented Apr 8, 2025

No description provided.

@ndegener-amd ndegener-amd requested a review from josel-amd April 9, 2025 06:14
josel-amd
josel-amd reviewed Apr 9, 2025
View reviewed changes
josel-amd
josel-amd reviewed Apr 9, 2025
View reviewed changes
josel-amd
josel-amd reviewed Apr 9, 2025
View reviewed changes
josel-amd
josel-amd reviewed Apr 9, 2025
View reviewed changes
josel-amd
josel-amd reviewed Apr 9, 2025
View reviewed changes
@josel-amd josel-amd requested review from TinaAMD and josel-amd April 9, 2025 07:43
TinaAMD
TinaAMD reviewed Apr 9, 2025
View reviewed changes
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback

@ndegener-amd ndegener-amd requested a review from TinaAMD April 10, 2025 11:09
josel-amd
josel-amd reviewed Apr 10, 2025
View reviewed changes
josel-amd
josel-amd reviewed Apr 10, 2025
View reviewed changes
TinaAMD
TinaAMD reviewed Apr 10, 2025
View reviewed changes
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpicks, looks nice overall already!

@ndegener-amd ndegener-amd requested a review from josel-amd April 14, 2025 07:41
ndegener-amd
ndegener-amd commented Apr 14, 2025
View reviewed changes
@josel-amd josel-amd requested a review from mgehre-amd April 14, 2025 14:27
mgehre-amd
mgehre-amd reviewed Apr 14, 2025
View reviewed changes
mgehre-amd
mgehre-amd reviewed Apr 14, 2025
View reviewed changes
mgehre-amd
mgehre-amd reviewed Apr 14, 2025
View reviewed changes
mgehre-amd
mgehre-amd reviewed Apr 14, 2025
View reviewed changes
josel-amd
josel-amd reviewed Apr 14, 2025
View reviewed changes
josel-amd
josel-amd approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@josel-amd josel-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it from my side. LGTM! Nice work :)

@ndegener-amd ndegener-amd requested a review from mgehre-amd April 15, 2025 11:19
mgehre-amd
mgehre-amd reviewed Apr 15, 2025
View reviewed changes
mgehre-amd
mgehre-amd approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@ndegener-amd ndegener-amd merged commit 5f55822 into feature/fused-ops Apr 16, 2025
4 checks passed
@ndegener-amd ndegener-amd deleted the niklas.variable_naming branch April 16, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TinaAMD TinaAMD TinaAMD left review comments

@josel-amd josel-amd josel-amd approved these changes

@mgehre-amd mgehre-amd mgehre-amd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ndegener-amd @mgehre-amd @TinaAMD @josel-amd