feat: Implement Secure Change Password Flow with Re-authentication and Audit Logging#568
Closed
Raaaghavagrawal wants to merge 3 commits into
Closed
Conversation
Member
|
The changes in this PR are quite extensive, especially around the change password flow. Additionally, some dependencies have been downgraded, and multiple unnecessary files have been introduced. There are also merge conflicts present. Given the scale and nature of these changes, it would not be safe to merge this PR in its current state, so I am closing it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a secure Change Password functionality for authenticated users within the account settings. It resolves an existing security and compliance gap by allowing users to update their credentials safely while enforcing password policies and requiring re-authentication.
Screenshots Or Recordings
Changes
Change Password Feature
a. Current password
b. New password
c. Confirm new password
Re-authentication
Password Validation
Error Handling and UX
a. Incorrect current password
b. Validation failures
c. Re-authentication errors
Telemetry and Audit Logging
a. User identifier
b. Timestamp
c. Status (success/failure)
d. Failure reason (if applicable)
Testing
Security Considerations
Checklist
✅Authenticated user can change password with correct current password
✅Incorrect current password handled with clear and secure error message
✅Password policy (length and strength) enforced
✅Re-authentication required before password update
✅Validation and auth errors handled gracefully
✅Success confirmation displayed to user
✅Session behavior handled after password change
✅Audit logging implemented for password change attempts
✅No sensitive data (passwords) logged
✅Basic test coverage added for validation and error cases
Out of Scope
✅Mandatory periodic password rotation policy