Update VoiceVisualizer.tsx #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add buttons type for all buttons because i am using this audio visualization package in a form and the default type of the button is submit when i click record, pause or stop i found the from submitted so if fixed it by adding type="button" for all buttons here to change the default type of html button from submit to button to prevent any form submit while clicking on any button of this package
|
fix: prevent form submission by adding type='button' to all buttons in audio visualization package |
1 similar comment
|
fix: prevent form submission by adding type='button' to all buttons in audio visualization package |
YZarytskyi
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add buttons type for all buttons because i am using this audio visualization package in a form and the default type of the button is submit
when i click record, pause or stop i found the from submitted so if fixed it by adding type="button" for all buttons here to change the default type of html button from submit to button to prevent any form submit while clicking on any button of this package