Add support for better error handling + provide API documentation #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmark
force-pushed
the
add_error_handler
branch
from
4d099e1 to
9500759
Compare
| }); | ||
| }); | ||
|
|
||
| test('batch endpoint (multiple requests, custom error handling)', async () => { |
| }); | ||
|
|
||
| test('batch endpoint (multiple requests, error handling)', async () => { | ||
| test('batch endpoint that throws errors', async () => { |
Contributor
There was a problem hiding this comment.
++, nice test.
Could we add one more test when the number of items are not match in request/response then throw BatchItemNotFound Error
Collaborator
Author
There was a problem hiding this comment.
We already have these tests:
I've gone ahead and asserted that these are actually BatchItemNotFound errors now tho :)
Collaborator
Author
There was a problem hiding this comment.
we could probably do with some better organization of these tests :P
ryanruanwork
suggested changes
Mar 26, 2020
Contributor
ryanruanwork
left a comment
ryanruanwork
left a comment
There was a problem hiding this comment.
Nice work! Could be great to add more tests and make test fail on CI. We may need to run make test to meet the requirement of pre-commit hooks.
This ended up being kind of two seperate efforts in one PR, sorry! Here's what's happening: - Add API_DOCS.md to provide full documentation for all of dataloader-codegen's options - Add some default error handling in the case that a resource returns an error - we don't want to blow up the whole batch - Add a new `errorHandler` option to the config to let folks override what happens to an error returned from a resource
magicmark
force-pushed
the
add_error_handler
branch
from
9500759 to
2e8f530
Compare
ryanruanwork
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being kind of two seperate efforts in one PR, sorry! 😬
Here's what's happening:
errorHandleroption to the config to let folks override what happens to an error returned from a resource