Update error handling logic to preserve custom error objects #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmark
force-pushed
the
fix_error_handling_logic_to_support_custom_errors
branch
4 times, most recently
from
aa53b50 to
0090829
Compare
magicmark
commented
Mar 31, 2020
| }); | ||
| }); | ||
|
|
||
| test('batch endpoint that throws errors', async () => { |
Collaborator
Author
There was a problem hiding this comment.
Removing this since it's the same test as
magicmark
force-pushed
the
fix_error_handling_logic_to_support_custom_errors
branch
from
0090829 to
c0ff8d5
Compare
ryanruanwork
approved these changes
Mar 31, 2020
Contributor
ryanruanwork
left a comment
ryanruanwork
left a comment
There was a problem hiding this comment.
Good catch. Shipit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a flaw in the
errorHandlerlogic. Because we wrap everything withensureError, any non-errors passed to errorHandler get serialized away, and we lose access to the underlying thing returned from the resource. In the case of a rejected promise (like a 2xx) we don't get access to the response object :(Let's change this, so that
errorHandlertakes inanyinstead oferror, so it can see the original thing returned from the resource.