Skip to content

Relax flow for the errorHandler, bump flow-bin and graphql in the examples #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

Relax flow for the errorHandler, bump flow-bin and graphql in the examples #50

merged 1 commit into from
Apr 3, 2020

Conversation

@magicmark
Copy link
Collaborator

@magicmark magicmark commented Apr 3, 2020 •
edited
Loading

  • Relax the flow from complaining about the usage of 'any' in strict mode for errorHandler
  • bump flow-bin and graphql in the examples

@magicmark magicmark changed the title Relax the typing for errorHandler, bump flow-bin and graphql in the examples Relax flow for the errorHandler, bump flow-bin and graphql in the examples Apr 3, 2020
@magicmark magicmark requested a review from ryanruanwork April 3, 2020 02:42
ryanruanwork
ryanruanwork approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@ryanruanwork ryanruanwork left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is it compatible with our own internal GraphQL service?

@magicmark
Copy link
Collaborator Author

magicmark commented Apr 3, 2020

LGTM! Is it compatible with our own internal GraphQL service?

yep, tested with yarn link

@magicmark magicmark merged commit 92bf37c into master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ryanruanwork ryanruanwork ryanruanwork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@magicmark @ryanruanwork