Datacratic #565
Open
Datacratic #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for ES 2
Also tweaked some comments and logging messages to help debugging.
Defaults to an empty string. It is not currently used by the builtin alerters, but custom alerters could make use of it to include a description or some context as to why a rule might trigger.
- Update docs regarding per rule max_query_size - set the default value at rule config time instead of before every search
- Remove functions copied from ElastAlerter - pass util and json in the jinja env - allow for a templated email subject via rule['alert_subject'] - change default subject to include the alert_time and number of matches
Also add a function to get a datetime from a prettified ts string.
Conflicts: elastalert/config.py
Conflicts: elastalert/config.py
Also dropped commented out code about num_matches
Conflicts: elastalert/config.py elastalert/elastalert.py
process_hits adds the metadata fields to _source and returns a list of _source dicts instead of relying on remove_duplicate_events to do that. remove_duplicate_events has been rewritten to do its work in a single pass through the data instead of 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.