Added code to pass the spark config required for some of the services #167
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
approved these changes
Nov 12, 2025
| 'service_account_name': service_account_name, | ||
| 'ui_port': int(ui_port), | ||
| 'user': os.environ.get('USER'), | ||
| 'aws_account_id': spark_conf.pop('aws_account_id', None), |
Member
There was a problem hiding this comment.
if we extract the account id code into a function and throw an lru_cache or something at it, then we could avoid using spark_conf as a way to pass short-lived data to this function - but i guess this is fine if y'all are fine with it :p
Contributor
Author
There was a problem hiding this comment.
i thought of that and felt short live is simpler and better than function and lru cache
timma-yelp
deleted the
timma/pass_config_required_for_some_of_the_services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code required to pass configs required for some of the services