301 Redirect won't work with Russian language - act II

[szepeviktor]

Upon entering http://keszul.tk/свидетельство/ into the 301 field, I get:

HTTP request sent, awaiting response...
  HTTP/1.0 301 Moved Permanently
  Date: Thu, 20 Mar 2014 19:24:58 GMT
  Server: Apache
  Set-Cookie: PHPSESSID=juqlj51vb1diidlmrne282uk52; path=/
  Expires: Thu, 19 Nov 1981 08:52:00 GMT
  Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
  Pragma: no-cache
  X-Pingback: http://keszul.tk/xmlrpc.php
  Location: http://keszul.tk//
  Vary: Accept-Encoding
  Content-Length: 0
  Connection: close
  Content-Type: text/html; charset=UTF-8

v1.5.2.4
original issue: #217

[jrfnl]

@szepeviktor Congratulations! You've discovered a bug in WP core ;-)

I've just tested this quite extensively and found that WPSEO passes the URL correctly to the WP core function wp_redirect().
Within wp_redirect() I've tested whether the url was received correctly and what happens with it after each step. The bug is in the wp_sanitize_redirect() function which cleans the non-latin utf-8 characters out.

Both the wp_redirect() and wp_sanitize_redirect() functions are pluggable, so you could overrule either of them to get this working on a site which needs it. I would however recommend filing a bug report with WP core (if one doesn't exists yet).

Closing as this is not a WPSEO bug.

[jrfnl]

@jdevalk @barrykooij We could try and work around this, but I'm not sure we'd want to do that. The steps would need to be something along the lines of:
a) detecting whether this is a relative or absolute url
b) parsing it
c) url_encoding the parts which need encoding
d) re-building the url
e) only then passing it on to wp_redirect()

[szepeviktor]

If the URL is passed in an encoded form like
wp_sanitize_redirect('http://keszul.tk/%D1%81%D0%B2%D0%B8%D0%B4%D0%B5%D1%82%D0%B5%D0%BB%D1%8C%D1%81%D1%82%D0%B2%D0%BE/');
it is OK.
Please pass the encoded URL and reopen this issue!

[szepeviktor]

Another failing issue in URLs is the IDN domain name like
http://esküvői-videók.hu/blog/
By the way I have a Keep Latin accents plugin: https://gist.github.com/szepeviktor/9682764

[szepeviktor]

I think the "bug" in wp_sanitize_redirect() is intended to redirect to valid URLs only.
IDN domain names and non-ascii URL paths should be encoded before usage.
The tricky part is URL path which should be also encoded but NOT / signs,
and spaces NOT to + but %20.

[szepeviktor]

But, yes: WordPress should be able do deal with both (IDN, non-ascii)

[jdevalk]

So, if we "fix" this, we're working around a bug in core, right? If so, I'd much rather escalate to core and get it fixed there. @nacin, our honorary polyglot, might be able to assist there...

[jrfnl]

Reopened to invite more opinions. I'm still of the opinion that WP should deal with this. Their code is obviously outdated since the change which allows non-latin characters in IDNs.

[jdevalk]

We think alike @jrfnl :)

[jdevalk]

There's actually a fairly old Trac ticket for this: https://core.trac.wordpress.org/ticket/10690

[jdevalk]

Closing, the more i look at it, we shouldn't fix this, core should.