Igorwulff patch 2 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mechanic for cleaning is still not efficient and batch size could be made higher possibly.
nkikkertyouwe
approved these changes
Apr 7, 2023
|
@igorwulff Please change the composer name of the module otherwise it will be hard to require it from packagist. |
leonhelmus
requested changes
Apr 7, 2023
| protected const WEBAPI_LOGS_IS_ENABLED_CONFIG_PATH = 'webapi_logs/log/enabled'; | ||
|
|
||
|
|
||
| protected const WEBAPI_LOGS_DISABLED_AJAX_CALLS = 'webapi_logs/log/disable_ajax_calls'; |
There was a problem hiding this comment.
Maybe make this private instead of protected.
| $this->lastLog = $log; | ||
| } catch (Exception $exception) { | ||
| $this->logger->error(__('Cant complete webapi log save because of error: %1', $exception->getMessage())); | ||
| if ($this->config->isSecretMode()) { |
There was a problem hiding this comment.
Are you sure about removing this try catch? It seems like it could trigger and should be catched.
leonhelmus
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.