Fix behavior with string unicodes diffs, fix #7 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caub
changed the title
caub
force-pushed
the
string-unicodes
branch
4 times, most recently
from
1caa108 to
0665c98
Compare
Contributor
Author
|
Well, neverming, actually, no even need to change the source code, I just left the unit test with unicodes |
YuJianrong
approved these changes
May 22, 2021
Owner
YuJianrong
left a comment
YuJianrong
left a comment
There was a problem hiding this comment.
Thanks, the new test cases works nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@YuJianrong Could you check this out please?