Skip to content

Conversation

@mchaynes
Copy link
Contributor

Decided that actually implementing logrus.Hook probably isn't the best way to go. Instead, just make an asynchronous io.Writer() that can be used for logging if wanted, or whatever else might be wanted

This allows us to use splunk as an output source in a much more flexible way
in particular, it allows us to be non blocking for uploading to splunk

Fixes: #6

This allows us to use splunk as an output source in a much more flexible way
in particular, it allows us to be non blocking for uploading to splunk

Fixes: #6
@mchaynes
Copy link
Contributor Author

Any chance you could take a look at this? @ZachtimusPrime

@ZachtimusPrime
Copy link
Owner

ZachtimusPrime commented Feb 15, 2019 via email

@ZachtimusPrime
Copy link
Owner

Looks nice! I appreciate the thought put in with this over implementing a direct logrus hook. Would you mind adding some documentation to the readme at the root of the project for your additions before I merge?

@mchaynes
Copy link
Contributor Author

Sure thing, I'll probably get that to you Monday realistically. Thanks for taking a look.

@mchaynes
Copy link
Contributor Author

@ZachtimusPrime, updated readme

@ZachtimusPrime ZachtimusPrime merged commit 6a3d71e into ZachtimusPrime:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants