Share Works #501
Merged
Share Works #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2022 18:55
…ollaborate with me 1. when user click the button, browser will open a new window show the github survey page 2. regarding the implements: 2.1 I have to add an empty function for the share button, I don't know how to avoid that 2.2 I might need to change the share button position
Contributor
我已经merge了部署到staging.zenuml.com 了。空的那个方法刚好可以用来给Google analytics 发送消息。你可以加一下这个逻辑。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#496: As a user, I want to share the diagram so that they can collaborate with me
2.1 I have to add an empty function for the share button, I don't know how to avoid that
2.2 I might need to change the share button position