Issue 148 connection helper #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsuaste
commented
Dec 9, 2020
vsuaste
commented
- Modify schema and models to handle direct access to nodes in type Connection queries.
- Unit test fixed
- Added integration test
|
If you merge, please make sure that the following issues are also taken care of:
|
wunderbarr
reviewed
Apr 9, 2021
.testenv.json
Outdated
| "name": "gql_science_db_graphql_server1", | ||
| "template": "https://github.com/Zendro-dev/graphql-server.git", | ||
| "branch": "master", | ||
| "branch": "issue-148-connection-helper", |
wunderbarr
reviewed
Apr 9, 2021
.testenv.json
Outdated
| "name": "gql_science_db_graphql_server2", | ||
| "template": "https://github.com/Zendro-dev/graphql-server.git", | ||
| "branch": "master", | ||
| "branch": "issue-148-connection-helper", |
don't push package-lock.json file to master branch
wunderbarr
reviewed
Apr 9, 2021
Comment on lines
3140
to
3142
| res = itHelpers.request_graph_ql_post_instance2('mutation{addSq_author(id:"remote_a2" name:"n2" addBooks:["remote_b1"]){id}}'); | ||
| expect(res.statusCode).to.equal(200); | ||
| res = itHelpers.request_graph_ql_post_instance2('mutation{addSq_author(id:"local_a2" name:"n2" addBooks:[ "local_b1"]){id}}'); |
There was a problem hiding this comment.
add bookConnection for the test
wunderbarr
reviewed
Apr 9, 2021
Comment on lines
+3130
to
+3132
| res = itHelpers.request_graph_ql_post('mutation{addAuthor(id:"remote_a1" name:"n1" addBooks:["remote_b1","remote_b2"]){id }}'); | ||
| expect(res.statusCode).to.equal(200); | ||
| res = itHelpers.request_graph_ql_post('mutation{addAuthor(id:"remote_a2" name:"n2" addBooks:["remote_b1"]){id}}'); |
There was a problem hiding this comment.
add booksConnection for the test
There was a problem hiding this comment.
This is not the test, this is only the setup for the test, which is below.
wunderbarr
requested changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.