Skip to content

Conversation

@davelsio
Copy link

@davelsio davelsio commented May 12, 2021

Summary

This PR makes some environment variables mandatory to start the server, removing defaults that could potentially be dangerous or lead hard to debug behavior.

Changes

  • Treat ALLOW_ORIGIN and JWT_SECRET variables as mandatory and remove their defaults.
  • Treat MAIL_* related variables as optional, but include no defaults.
  • If MAIL_* variables are not set, the sendEmail service will throw the appropriate error.

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant