Skip to content

Conversation

@ion098
Copy link
Contributor

@ion098 ion098 commented Mar 28, 2025

Overview

Motivation

References (optional)

Closes #29

Implementation Details (optional)

Test Plan:

@djava
Copy link
Contributor

djava commented Apr 29, 2025

BTW I would prefer that if you make a change related to one of my comments, just respond with the hash of the commit that fixes it and don't resolve - i'll either resolve or suggest a different fix

And feel free to argue and stuff if you disagree as well, that's the point of all this

@SizzinSeal
Copy link
Member

I'd like to see some more tests before this merges, I think. In particular, I think that the multiple-errors case is probably where most of the snags lie, and the tests don't currently cover that.

Yea that's next on the to-do list, along with better docs and formatting

@SizzinSeal
Copy link
Member

I'm marking this as ready for review. I wasn't able to implement all the features I've planned to (notably std::format support), but what we have right now is enough to get started with other tasks.

@SizzinSeal SizzinSeal marked this pull request as ready for review May 2, 2025 23:21
@SizzinSeal SizzinSeal requested a review from jmakif May 2, 2025 23:23
@SizzinSeal SizzinSeal requested a review from meisZWFLZ May 2, 2025 23:23
@SizzinSeal SizzinSeal assigned SizzinSeal and unassigned ion098 May 2, 2025
@SizzinSeal SizzinSeal requested a review from djava May 3, 2025 02:10
@SizzinSeal
Copy link
Member

Everyone is busy, all the tests passed, and the design has been debated to death. So this is getting merged

@SizzinSeal SizzinSeal merged commit 2834fd9 into main May 3, 2025
2 checks passed
@SizzinSeal SizzinSeal deleted the feat/better-errors branch May 3, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻ Rework Error Types

4 participants