Skip to content

feat: Minor log enhancement - tool version included #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: Minor log enhancement - tool version included #102

merged 1 commit into from
Sep 17, 2024

Conversation

@chandrasekharan-zipstack
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack commented Sep 17, 2024 •
edited
Loading

What

  • Included tool version also in the initial tool run log
  • Removed a scenario where an env EXECUTION_BY_TOOL was set
  • SDK version is not bumped and can be clubbed with any subsequent release

Why

  • More context -> to avoid asking user / checking releases to figure this out
  • EXECUTION_BY_TOOL is set and passed by the runner before the tool starts as it should be

Related Issues or PRs

Notes on Testing

Checklist

I have read and understood the Contribution Guidelines.

@ritwik-g ritwik-g merged commit 84f4985 into main Sep 17, 2024
@ritwik-g ritwik-g deleted the feat/include-tool-version-in-log branch September 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Deepak-Kesavan Deepak-Kesavan Deepak-Kesavan approved these changes

@ritwik-g ritwik-g ritwik-g approved these changes

@gaya3-zipstack gaya3-zipstack Awaiting requested review from gaya3-zipstack

Assignees

@chandrasekharan-zipstack chandrasekharan-zipstack

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chandrasekharan-zipstack @Deepak-Kesavan @ritwik-g