[FEAT] Adapter for LLMWhisperer v2 #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harini-venkataraman
requested review from
Deepak-Kesavan,
chandrasekharan-zipstack,
gaya3-zipstack,
hari-kuriakose and
johnyrahul
Contributor
chandrasekharan-zipstack
left a comment
chandrasekharan-zipstack
left a comment
There was a problem hiding this comment.
Left some minor comments. Please bump the SDK version as well.
src/unstract/sdk/adapters/x2text/llm_whisperer/src/static/json_schema.json
Outdated
Show resolved
Hide resolved
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/constants.py
Outdated
Show resolved
Hide resolved
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Outdated
Show resolved
Hide resolved
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Outdated
Show resolved
Hide resolved
johnyrahul
reviewed
Oct 17, 2024
johnyrahul
reviewed
Oct 17, 2024
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Show resolved
Hide resolved
johnyrahul
reviewed
Oct 17, 2024
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Outdated
Show resolved
Hide resolved
johnyrahul
approved these changes
Oct 17, 2024
Contributor
johnyrahul
left a comment
johnyrahul
left a comment
There was a problem hiding this comment.
Changes LGTM, Few minor comments.
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/helper.py
Outdated
Show resolved
Hide resolved
gaya3-zipstack
approved these changes
Oct 17, 2024
Contributor
gaya3-zipstack
left a comment
gaya3-zipstack
left a comment
There was a problem hiding this comment.
Added one minor suggestion
@Harini
Other than that, looks in-line to me.
Signed-off-by: Jaseem Jas <89440144+jaseemjaskp@users.noreply.github.com>
|
|
Deepak-Kesavan
approved these changes
Oct 17, 2024
…dk into feat/llmwhisperer-v2
chandrasekharan-zipstack
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
PR to support adapter for LLMWhispererv2 version
...
Why
LLMWhisperer has some major changes which has new params introduced and removal of async mode of execution.
This new adapter supports this breaking change
...
How
Addition of new adapter.
...
Relevant Docs
https://github.com/Zipstack/llmwhisperer-docs/blob/v2-docs/docs/llm_whisperer/apis/whisper.md
...
Related Issues or PRs
Not applicable
...
Dependencies Versions / Env Variables
|
ADAPTER_LLMW_POLL_INTERVAL| Time in seconds to wait before polling LLMWhisperer's status API. Defaults to 30s ||
ADAPTER_LLMW_MAX_POLLS| Total number of times to poll the status API. Defaults to 30 |...
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.