[FIX] Refactored indexing, extraction and retrieval #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
harini-venkataraman
changed the title
harini-venkataraman
force-pushed
the
fix/indexing-refactor
branch
from
cbea093 to
025b0ce
Compare
Contributor
chandrasekharan-zipstack
left a comment
chandrasekharan-zipstack
left a comment
There was a problem hiding this comment.
Left some comments - my main question is on why we have such helper methods for indexing and an API call to the prompt-service
Deepak-Kesavan
approved these changes
Mar 17, 2025
chandrasekharan-zipstack
approved these changes
Mar 18, 2025
Contributor
chandrasekharan-zipstack
left a comment
chandrasekharan-zipstack
left a comment
There was a problem hiding this comment.
LGTM - left a nit comment
Signed-off-by: harini-venkataraman <115449948+harini-venkataraman@users.noreply.github.com>
…sdk into fix/indexing-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
...
Why
Pre requisite for cell type merge
...
How
Refactored the existing code
...
Relevant Docs
Related Issues or PRs
Zipstack/unstract#1172
Zipstack/unstract#1149
...
Dependencies Versions / Env Variables
Notes on Testing
Added integration tests
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.