Skip to content

Conversation

@chandrasekharan-zipstack
Copy link
Contributor

What

  • Removed unstract-connectors from the SDK's dependencies and updated the lock file
  • Removed unused code - dbs, filesystems, documents and its test cases
    NOTE: These changes are not yet published and can go in with other planned changes around index.py

Why

  • This package was used for the old architecture and by doing this we can avoid publishing/maintaining unstract-connectors as a public repo

How

...

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

  • Tried importing the deleted modules and they throw an import error as expected

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

Removed unused code - dbs, filesystems, documents and its test cases
Copy link
Contributor

@muhammad-ali-e muhammad-ali-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaseemjaskp jaseemjaskp merged commit 220e005 into main Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants