Skip to content

fix: Minor error handling in metadata read, log fix in index #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: Minor error handling in metadata read, log fix in index #21

merged 1 commit into from
Mar 21, 2024

Conversation

@chandrasekharan-zipstack
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack commented Mar 21, 2024

What

  • Minor JSON decode error handling in metadata read
  • Fixed an incorrect log message in index.py

NOTE: Since its a minor change, version has not been explicitly bumped - it can go along with #20

Why

  • Without this error handling, we didn't have context on where the error was coming from / the file that caused it

How

...

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

  • An incorrect metadata.json returned the expected error with information on the file that caused it

Screenshots

...

Checklist

I have read and understood the Contribution Guidelines.

vishnuszipstack
vishnuszipstack approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@vishnuszipstack vishnuszipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

muhammad-ali-e
muhammad-ali-e approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@muhammad-ali-e muhammad-ali-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaseemjaskp jaseemjaskp merged commit 29a22c6 into main Mar 21, 2024
@jaseemjaskp jaseemjaskp deleted the fix/json-decode-error-handled-for-tool-metadata branch March 21, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muhammad-ali-e muhammad-ali-e muhammad-ali-e approved these changes

@vishnuszipstack vishnuszipstack vishnuszipstack approved these changes

@nehabagdia nehabagdia Awaiting requested review from nehabagdia

@Deepak-Kesavan Deepak-Kesavan Awaiting requested review from Deepak-Kesavan

Assignees

@chandrasekharan-zipstack chandrasekharan-zipstack

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chandrasekharan-zipstack @muhammad-ali-e @vishnuszipstack @jaseemjaskp