fix: Indexing related improvements and fixes #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrasekharan-zipstack
requested review from
Deepak-Kesavan,
gaya3-zipstack,
hari-kuriakose,
muhammad-ali-e and
nehabagdia
Contributor
gaya3-zipstack
left a comment
gaya3-zipstack
left a comment
There was a problem hiding this comment.
@chandrasekharan-zipstack The changes look fine. If you can test it quickly against Postgres and Supabase, we are good to roll!
Contributor
Author
|
@gaya3-zipstack I got these results with postgres and supabase respectively - not sure if its expected but I think supabase has a known failure around this
|
Signed-off-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
gaya3-zipstack
approved these changes
Mar 25, 2024
Contributor
gaya3-zipstack
left a comment
gaya3-zipstack
left a comment
There was a problem hiding this comment.
Looks fine. @chandrasekharan-zipstack Chandru has confirmed testing with Postgres and Supabase and no query failures seen.
jaseemjaskp
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
index_file()Why
How
...
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
0.16.1Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.